Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added error msg to forc-init when proj-name is test #1144

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Added error msg to forc-init when proj-name is test #1144

merged 4 commits into from
Apr 6, 2022

Conversation

eureka-cpu
Copy link
Contributor

Closes #1126

@eureka-cpu eureka-cpu added bug Something isn't working forc labels Apr 4, 2022
@eureka-cpu eureka-cpu requested a review from mohammadfawaz April 4, 2022 21:04
@eureka-cpu eureka-cpu self-assigned this Apr 4, 2022
mohammadfawaz
mohammadfawaz suggested changes Apr 4, 2022
View reviewed changes
forc/src/ops/forc_init.rs Outdated Show resolved Hide resolved
@eureka-cpu eureka-cpu requested a review from mohammadfawaz April 5, 2022 16:47
@mohammadfawaz
Copy link
Contributor

I noticed that there is a function called validate_name in https://github.com/FuelLabs/sway/blob/3c8cb7b52d5ff4d06684277bf07de228df8f6673/forc-util/src/lib.rs that has a bunch of checks. Can we maybe call that function instead of adding the checks manually in forc-init.rs?

mohammadfawaz
mohammadfawaz reviewed Apr 5, 2022
View reviewed changes
forc-util/src/lib.rs Outdated Show resolved Hide resolved
@eureka-cpu eureka-cpu requested a review from mohammadfawaz April 6, 2022 06:05
mohammadfawaz
mohammadfawaz approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@mohammadfawaz mohammadfawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

sezna
sezna approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eureka-cpu eureka-cpu merged commit bbe2938 into master Apr 6, 2022
@eureka-cpu eureka-cpu deleted the eureka-cpu/forc-init-test-error branch April 6, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

@sezna sezna sezna approved these changes

Assignees

@eureka-cpu eureka-cpu

Labels
bug Something isn't working forc
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have forc init fail when the project name is test
3 participants
@eureka-cpu @mohammadfawaz @sezna