Add a reverse map for looking up metadata location indices. #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves performance a fair bit as it was doing an O(n) search for the location when creating any new span.
otrho
added
code quality
compiler: ir
|
I'm not super happy with adding the cache right there into the IR Context, but it's better than nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance a fair bit as it was doing an O(n) search for the location when creating any new span.
It reduces the time for me to run the E2E tests by about 30%, which is OK.
I don't see any obvious outliers in the profile any more but there are very likely some higher level algorithmic changes we could make, and identifying redundant work. I'm especially suspicious of the function construction the IR does when compiling a call, which will recreate every function called redundantly. It's very hard to avoid this at the moment though, since functions have no unique identifiers -- we need to enforce using full module callpaths. Right now they're still optional.