Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use const values for offsets in call_frames module #1157

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Use const values for offsets in call_frames module #1157

merged 1 commit into from
Apr 5, 2022

Conversation

nfurfaro
Copy link
Contributor

@nfurfaro nfurfaro commented Apr 5, 2022

Now that IR is on, we can use const values in libraries.
closes #1127

@nfurfaro nfurfaro added lib: std Standard library code quality labels Apr 5, 2022
@nfurfaro nfurfaro self-assigned this Apr 5, 2022
@nfurfaro nfurfaro requested a review from emilyaherbert April 5, 2022 17:45
mohammadfawaz
mohammadfawaz approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@mohammadfawaz mohammadfawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that there is a passing test that exercises this, this looks good!

@nfurfaro
Copy link
Contributor Author

nfurfaro commented Apr 5, 2022 •
edited by adlerjohn
Loading

Assuming that there is a passing test that exercises this...

yes, our call_frames tests wouldn't even build before when trying to use these const values like this.
Now they build and pass.

@nfurfaro nfurfaro merged commit 35cac1b into master Apr 5, 2022
@nfurfaro nfurfaro deleted the furnic/use-consts-in-callframes branch April 5, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

@emilyaherbert emilyaherbert Awaiting requested review from emilyaherbert

Assignees

@nfurfaro nfurfaro

Labels
code quality lib: std Standard library
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use const values in call_frames module
2 participants
@nfurfaro @mohammadfawaz