Explicitly declare [lib] and [[bin]] targets for forc
#1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to remove some duplication between the `lib.rs` and `main.rs` modules, and should allow us to remove the catch-all `#![allow(dead_code)]` attributes.
mitchmindtree
requested review from
JoshuaBatty,
adlerjohn,
digorithm,
sezna and
emilyaherbert
JoshuaBatty
approved these changes
Apr 7, 2022
mitchmindtree
added a commit
that referenced
this pull request
Apr 7, 2022
This was originally required in order to support the separate implicit `bin` and `lib` targets for `forc` without getting loads of warnings, but as of #1174 `cargo` is aware of the separate targets and this is no longer necessary.
mitchmindtree
added a commit
that referenced
this pull request
Apr 7, 2022
This was originally required in order to support the separate implicit `bin` and `lib` targets for `forc` without getting loads of warnings, but as of #1174 `cargo` is aware of the separate targets and this is no longer necessary.
mitchmindtree
added a commit
that referenced
this pull request
Apr 7, 2022
* Remove `#![allow(dead_code)]` from `forc` along with dead code This was originally required in order to support the separate implicit `bin` and `lib` targets for `forc` without getting loads of warnings, but as of #1174 `cargo` is aware of the separate targets and this is no longer necessary. * Remove old feature-gated start_fuel_core re-export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to remove some duplication between the
lib.rsandmain.rsmodules, and should allow us to remove the catch-all#![allow(dead_code)]attribute inlib.rsin a follow-up PR.