Move forc's fmt command support into a dedicated forc-fmt plugin crate
#1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for removing internal support for formatting from `forc` as a part of an ongoing effort toward slimming down `forc`'s dependency graph.
mitchmindtree
requested review from
JoshuaBatty,
adlerjohn,
sezna,
iqdecay and
eureka-cpu
JoshuaBatty
approved these changes
Apr 8, 2022
sezna
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1178.
This slims down
forca little further, and matchescargo's behaviour of shipping the formatter under a dedicated plugin. Incargo's case, many folk aren't even awarecargo fmtis provided by a plugin! I think we can provide an on-par experience once we get aforcuptool or similar going.In the meantime (once they're published) you can install
forcwith theforc-fmtplugin crate like so:For sway devs who wish to install from local src, the best one-liner I can think of is:
$ cargo install --path ./forc ; cargo install --path ./forc-fmtThis also removes the
FormatErrortype in favour of using the strictly more flexibleanyhow::Error.