-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing custom Span type. #198
Conversation
Looks pretty solid so far, exactly what I was envisioning 😄 |
Could you clarify why we need to change all of our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although, for future reference, we should store a &'manifest PathBuf
instead of a PathBuf
to avoid all the allocations.
Closes #152.
This PR implements a custom span type that allows the
Span
to keep track of the filename. This is useful because it could allow for users to see more descriptive error messages (#214#73 ). As a biproduct of this change, the error types in the compiler had to change as well, with any&'sc str
components changing toString
components, among other small changes.Summary
Span
Span