-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sway-fmt-v2 adds program type to the output #1997
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d8da8ca
program type handling for sway-fmt-v2 implemented
kayagokalp 94239be
program_type.rs added
kayagokalp e1e53ba
Merge branch 'master' into kayagokalp/1995
eureka-cpu 0fc8fff
use statements merged
kayagokalp 1883764
Merge branch 'master' into kayagokalp/1995
eureka-cpu 03d979c
test for program type included
kayagokalp 13ba03a
Merge branch 'master' into kayagokalp/1995
eureka-cpu ecb53d3
master merged & tests updated
kayagokalp fa3ebf5
Merge branch 'master' into kayagokalp/1995
eureka-cpu d3c812e
Merge branch 'master' into kayagokalp/1995
eureka-cpu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ pub mod attributes; | |
pub mod bracket; | ||
pub mod indent_style; | ||
pub mod newline_style; | ||
pub mod program_type; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
use sway_parse::ModuleKind; | ||
use sway_types::Spanned; | ||
|
||
/// Insert the program type without applying a formatting to it. | ||
/// | ||
/// Possible list of program types: | ||
/// - Script | ||
/// - Contract | ||
/// - Predicate | ||
/// - Library | ||
pub(crate) fn insert_program_type(push_to: &mut String, module_kind: ModuleKind) { | ||
match module_kind { | ||
ModuleKind::Script { script_token } => push_to.push_str(script_token.span().as_str()), | ||
ModuleKind::Contract { contract_token } => push_to.push_str(contract_token.span().as_str()), | ||
ModuleKind::Predicate { predicate_token } => { | ||
push_to.push_str(predicate_token.span().as_str()) | ||
} | ||
ModuleKind::Library { | ||
library_token, | ||
name, | ||
} => { | ||
push_to.push_str(library_token.span().as_str()); | ||
push_to.push(' '); | ||
push_to.push_str(name.as_str()); | ||
} | ||
}; | ||
push_to.push(';'); | ||
push_to.push('\n'); | ||
push_to.push('\n'); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the separate program type test which was not testing things correctly (even though I remove the changes from this PR, it wouldn't fail as the failure depends on the presence of other items in the source code that we are trying to format). Although we do not have any separate test for program type, it is checked in each test.