Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add input/output type constants to std-lib #2187

Merged
merged 18 commits into from
Jul 4, 2022
Merged

add input/output type constants to std-lib #2187

merged 18 commits into from
Jul 4, 2022

Conversation

simonr0204
Copy link
Contributor

@simonr0204 simonr0204 commented Jun 30, 2022 •
edited
Loading

Resolves #2186 in concordance with InputType and OutputType

@simonr0204 simonr0204 requested a review from nfurfaro June 30, 2022 15:09
@simonr0204 simonr0204 self-assigned this Jun 30, 2022
@simonr0204 simonr0204 marked this pull request as ready for review June 30, 2022 15:27
@simonr0204 simonr0204 requested a review from otrho as a code owner June 30, 2022 15:27
@simonr0204
Copy link
Contributor Author

Any thoughts on whether these should go into std::constants or std::tx ?

@nfurfaro
Copy link
Contributor

I would say add them to std::tx.

otrho
otrho previously approved these changes Jul 1, 2022
View reviewed changes
sway-lib-std/src/u128.sw Outdated Show resolved Hide resolved
@adlerjohn adlerjohn added lib: std Standard library enhancement New feature or request labels Jul 2, 2022
adlerjohn
adlerjohn suggested changes Jul 2, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert formatting changes since they're orthogonal.

sway-lib-std/src/u256.sw Outdated Show resolved Hide resolved
otrho
otrho reviewed Jul 4, 2022
View reviewed changes
sway-lib-std/src/u128.sw Outdated Show resolved Hide resolved
@simonr0204 simonr0204 requested a review from adlerjohn July 4, 2022 02:26
@simonr0204 @otrho
Update sway-lib-std/src/u128.sw
d6860d0 
Co-authored-by: Toby Hutton <toby@grusly.com>
Simon Roberts added 2 commits July 3, 2022 22:41
adlerjohn
adlerjohn previously approved these changes Jul 4, 2022
View reviewed changes
@adlerjohn adlerjohn requested a review from otrho July 4, 2022 03:13
nfurfaro
nfurfaro previously approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@nfurfaro nfurfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@simonr0204 simonr0204 dismissed stale reviews from nfurfaro and adlerjohn via 1914855 July 4, 2022 13:33
@simonr0204 simonr0204 merged commit 09edcb5 into master Jul 4, 2022
@simonr0204 simonr0204 deleted the simon-input-output-type-constants branch July 4, 2022 17:24
@simonr0204 simonr0204 mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

@nfurfaro nfurfaro nfurfaro approved these changes

@adlerjohn adlerjohn adlerjohn left review comments

@otrho otrho Awaiting requested review from otrho

Assignees

@simonr0204 simonr0204

Labels
enhancement New feature or request lib: std Standard library
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add input/output type constants to std-lib
6 participants
@simonr0204 @nfurfaro @otrho @adlerjohn @mohammadfawaz @sezna