Check for calling of associated functions as method calls. #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
added
the
compiler
tritao
force-pushed
the
associated-methods
branch
from
9b6dc71 to
c80572f
Compare
sezna
suggested changes
Jul 1, 2022
test/src/e2e_vm_tests/test_programs/should_fail/associated_fn_as_method_call/Forc.toml
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_fail/associated_fn_params_as_method_call/Forc.toml
Outdated
Show resolved
Hide resolved
tritao
force-pushed
the
associated-methods
branch
from
4a7ef01 to
a6f60cc
Compare
mohammadfawaz
previously approved these changes
Jul 4, 2022
|
Merge conflicts! |
This adds a new error and checking for calls of associated functions
using method call syntax.
This means for code like the following:
```
struct Bar {}
impl Bar {
fn associated() {}
}
fn main() -> u64 {
let bar = Bar {};
bar.associated();
0
}
```
we now emit an error:
```
error
--> main.sw:11:3
|
9 |
10 | let bar = Bar {};
11 | bar.associated();
| ^^^^^^^^^^^^^^^^ Cannot call associated function "associated" as
method call. Use associated function syntax instead.
12 | 0
13 | }
|
```
This brings us closer to Rust behaviour, which also checks for this and
only allows functions taking a self to be called with method call
syntax.
It adds a few more tests for this and also updates some standard library
trait methods to take self so they work with the new check.
tritao
force-pushed
the
associated-methods
branch
from
a6f60cc to
3ca7651
Compare
mohammadfawaz
approved these changes
Jul 4, 2022
@sezna this PR requires your review again :) |
sezna
approved these changes
Jul 5, 2022
r-sitko
pushed a commit
to r-sitko/sway
that referenced
this pull request
Jul 6, 2022
…2198) This adds a new error and checking for calls of associated functions using method call syntax. This means for code like the following: ``` struct Bar {} impl Bar { fn associated() {} } fn main() -> u64 { let bar = Bar {}; bar.associated(); 0 } ``` we now emit an error: ``` error --> main.sw:11:3 | 9 | 10 | let bar = Bar {}; 11 | bar.associated(); | ^^^^^^^^^^^^^^^^ Cannot call associated function "associated" as method call. Use associated function syntax instead. 12 | 0 13 | } | ``` This brings us closer to Rust behaviour, which also checks for this and only allows functions taking a self to be called with method call syntax. It adds a few more tests for this and also updates some standard library trait methods to take self so they work with the new check. Co-authored-by: Emily Herbert <17410721+emilyaherbert@users.noreply.github.com> Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new error and checking for calls of associated functions using method call syntax.
This means for code like the following:
we now emit an error:
This brings us closer to Rust behaviour, which to my understanding also checks for this and only allows method call syntax for functions taking self.
It adds a few more tests for this and also updates some standard library trait methods to take self so they work with the new check.