Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Span to break and continue declarations #2213

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

mohammadfawaz
Copy link
Contributor

@mohammadfawaz mohammadfawaz commented Jul 4, 2022

Needed for sway-lsp

Ref: #2117 (comment)

@mohammadfawaz mohammadfawaz self-assigned this Jul 4, 2022
@mohammadfawaz mohammadfawaz added enhancement New feature or request compiler: ir IRgen and sway-ir including optimization passes compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser labels Jul 4, 2022
@mohammadfawaz mohammadfawaz requested review from a team and JoshuaBatty July 4, 2022 15:46
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mohammadfawaz

@mohammadfawaz mohammadfawaz merged commit 8592e50 into master Jul 5, 2022
@mohammadfawaz mohammadfawaz deleted the mohammadfawaz/add_span_to_break_and_continue branch July 5, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: ir IRgen and sway-ir including optimization passes compiler: parser Everything to do with the parser enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants