Type arguments in JSON ABI and the function selector #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadfawaz
added
enhancement
otrho
previously approved these changes
Jul 5, 2022
|
Is there an issue in |
I created an issue for the full feature here: FuelLabs/fuels-rs#448. |
otrho
approved these changes
Jul 6, 2022
tritao
approved these changes
Jul 6, 2022
sezna
reviewed
Jul 6, 2022
| type_arguments: self | ||
| .type_id | ||
| .get_type_parameters() | ||
| .map(|v| v.iter().map(|param| param.generate_json_abi()).collect()), |
There was a problem hiding this comment.
code golf: .map(TypeParameter::generate_json_abi)
| type_arguments: x | ||
| .type_id | ||
| .get_type_parameters() | ||
| .map(|v| v.iter().map(|param| param.generate_json_abi()).collect()), |
There was a problem hiding this comment.
similar golf can be played here
| type_arguments: self | ||
| .type_id | ||
| .get_type_parameters() | ||
| .map(|v| v.iter().map(|param| param.generate_json_abi()).collect()), |
There was a problem hiding this comment.
i'm running out of creativity but the same code golf could apply here
| type_arguments: self | ||
| .return_type | ||
| .get_type_parameters() | ||
| .map(|v| v.iter().map(|param| param.generate_json_abi()).collect()), |
There was a problem hiding this comment.
why go for par when you can go for a birdie?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1993
Spec change in FuelLabs/fuel-specs#382
Mostly similar to how
componentswork.I had to switch to using copies of
PropertyandFunctionfromfuels-typesto local versions insway-typesbecausetype_argumentsstill need to be added infuels-types. This is temporary untilfuels-typesis ready.