Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some small issues in compiling load and store IR instructions when the word offset is > 4096 #2252

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Fix some small issues in compiling load and store IR instructions when the word offset is > 4096 #2252

merged 4 commits into from
Jul 8, 2022

Conversation

mohammadfawaz
Copy link
Contributor

@mohammadfawaz mohammadfawaz commented Jul 6, 2022 •
edited
Loading

Closes #2240

@mohammadfawaz mohammadfawaz self-assigned this Jul 6, 2022
@mohammadfawaz mohammadfawaz added compiler: codegen Everything to do with IR->ASM, register allocation, etc. bug Something isn't working P: critical Should be looked at before anything else labels Jul 6, 2022
@mohammadfawaz mohammadfawaz changed the title Fix a small issue in compiling load instructions Fix some small issues in compiling load and store IR instructions Jul 6, 2022
@mohammadfawaz mohammadfawaz changed the title Fix some small issues in compiling load and store IR instructions Fix some small issues in compiling load and store IR instructions when the word offset is > 4096 Jul 7, 2022
@mohammadfawaz mohammadfawaz marked this pull request as ready for review July 7, 2022 13:26
@mohammadfawaz mohammadfawaz requested a review from a team July 7, 2022 13:26
@mohammadfawaz mohammadfawaz mentioned this pull request Jul 7, 2022
Merged
4 tasks
otrho
otrho approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@otrho otrho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. 👍

@mohammadfawaz mohammadfawaz requested a review from a team July 8, 2022 15:12
@mohammadfawaz mohammadfawaz merged commit fcd6927 into master Jul 8, 2022
@mohammadfawaz mohammadfawaz deleted the mohammadfawaz/2240 branch July 8, 2022 19:27
@mohammadfawaz mohammadfawaz mentioned this pull request Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sezna sezna sezna approved these changes

@otrho otrho otrho approved these changes

Assignees

@mohammadfawaz mohammadfawaz

Labels
bug Something isn't working compiler: codegen Everything to do with IR->ASM, register allocation, etc. P: critical Should be looked at before anything else
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build hangs on large crypto code
3 participants
@mohammadfawaz @otrho @sezna