-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intrinsics for the VM's storage opcodes. #2508
Merged
Merged
Changes from 21 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
ecee49b
Add storage load/store word intrinsics
vaivaswatha 4ab8013
Storage load/store quad intrinsics
vaivaswatha 9863a44
Merge branch 'master' into vaivaswatha/storage_intrinsics
vaivaswatha 2c0a816
Update hash of a test
vaivaswatha 3aee84a
fix clippy
vaivaswatha 26807c7
Process key_reg after val_reg to avoid diffs in asm gen tests
vaivaswatha 799b981
Merge branch 'master' into vaivaswatha/storage_intrinsics
vaivaswatha e7f8168
Fix a deployment based test with right hash
vaivaswatha 75e7a9c
Add asm gen test
vaivaswatha ca164d3
Merge branch 'master' into vaivaswatha/storage_intrinsics
vaivaswatha 82a2e6e
Check arguments after monomorphization, during IR gen
vaivaswatha 88e954d
Replace asm with intrinsics in storage.sw
vaivaswatha 2c2015f
Restore storage.sw
vaivaswatha d1f11e2
minor fixes
vaivaswatha ba5e609
Update storage.sw and add exhaustive tests
vaivaswatha 4d433e3
Merge branch 'master' into vaivaswatha/storage_intrinsics
vaivaswatha 66fe14c
Update JSON ABI
vaivaswatha cad780b
Move cfei into an alloca lib function
vaivaswatha 6db548d
Update contract hash in calling script
vaivaswatha a6a59d1
Revert "Move cfei into an alloca lib function"
vaivaswatha 594a5b9
Revert "Update contract hash in calling script"
vaivaswatha fa82947
Merge remote-tracking branch 'origin/master' into vaivaswatha/storage…
vaivaswatha a27f9b3
Merge branch 'master' into vaivaswatha/storage_intrinsics
vaivaswatha 80858ab
Merge branch 'master' into vaivaswatha/storage_intrinsics
sezna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than special case
IntToPtr
here would it work instead to updateresolve_ptr()
to handle bothGetPointer
andIntToPtr
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered that, but there's some computation that's done later which isn't needed for
IntToPtr
(but needed if resolved as a stack pointer inresolve_ptr
. So it wouldn't serve any purpose since I'll need to handle them differently here anyway.