Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow asm expressions without returns #253

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Allow asm expressions without returns #253

merged 2 commits into from
Sep 21, 2021

Conversation

sezna
Copy link
Contributor

@sezna sezna commented Sep 21, 2021

Closes #244

Allows ASM expressions to optionally not return a register if their expected type is Unit.

@sezna sezna added enhancement New feature or request compiler General compiler. Should eventually become more specific as the issue is triaged labels Sep 21, 2021
@sezna sezna self-assigned this Sep 21, 2021
otrho
otrho approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@otrho otrho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's almost too easy.

@sezna sezna merged commit 8d68088 into master Sep 21, 2021
@sezna sezna deleted the sezna/244 branch September 21, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otrho otrho otrho approved these changes

@emilyaherbert emilyaherbert Awaiting requested review from emilyaherbert

Assignees

@sezna sezna

Labels
compiler General compiler. Should eventually become more specific as the issue is triaged enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inline asm blocks shouldn't have to return a value.
2 participants
@sezna @otrho