rustfmt.toml proposal

[emilyaherbert]

I propose that we start using a rustfmt.toml file to illicit more regulated and more documented formatting requirements.

See: https://rust-lang.github.io/rustfmt/?version=v1.4.36&search=

[sezna]

We have not yet had any complaints about the default settings, is there a particular formatting gripe that motivated this? It will be a hard PR to take because it will cause conflicts across the board for all of us currently working in the repository.

[emilyaherbert]

Totally fair. I should have explained this more but I more wanted to demonstrate what the rustfmt.toml file does. Introducing a rustfmt.toml file allows us to regulate formatting requirements across repositories, especially if we wanted to include non-default formatting settings.

In the meantime I will revert the changes to default settings. (Although personally I like the more condensed-code settings 😄 )

[adlerjohn]

Generally in favor of explicit over implicit. We can change the defaults at a later time if we want. Can you also introduce this formatting requirement (along with the file itself) into https://github.com/FuelLabs/rfcs?

[emilyaherbert]

See: FuelLabs/rfcs#8

[sezna]

I agree that explicit is better than implicit, and we should start with the defaults for now for ease of adoption. If we have any gripes with the settings as they are, we can open subsequent bikeshedding issues for that.

I just checked out this branch and verified that no diffs are generated by this toml, which is confirmed by the formatting check in actions. LGTM!