Update use declarations.
#266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otrho
force-pushed
the
otrho/187_update_use_decls
branch
from
482fec7 to
1f1dd57
Compare
Previously `use` would copy everything from the referenced module into the current namespace. This is problematic for special overrides like our binary operators. E.g., `==` is translated to `eq()` in the `std::ops::Ord` trait. If we copy `std::ops::Ord` to the local namespace (via `use std::ops::Ord;`) then we're creating an `Ord` impl there instead of in `std::ops` where they're expected. This change does not copy anything any more, but rather maintains a list of the `use` symbol synonyms and whenever they're queried relatively (without a module path) then the synonym path is used.
otrho
force-pushed
the
otrho/187_update_use_decls
branch
from
1f1dd57 to
d438d18
Compare
Do you mean like this? https://github.com/FuelLabs/sway/blob/master/core_lang/src/semantic_analysis/namespace.rs#L24 |
sezna
approved these changes
Sep 27, 2021
|
No, more like there's 1 namespace with an API to manage the collection of all the modules. Maybe it could be encapsulated differently. Doesn't matter, this is working. 👍 |
adlerjohn
added
the
compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #187.
Instead of copying and/or merging from namespaces for
usedeclarations we now keep a list ofusesynonyms. When an unqualified/relative symbol lookup is made the synonyms can be used to find the path to its module.I added a new test, taken from #187 and it's passing all the existing tests, but I feel like the whole system is still a bit fragile and could probably do with a bit of a refactor, now that we have it fairly stable. In the future we may wish to support partial paths -- e.g.,
use std::hashand thenhash::hash_value(...). While looking at the code I feel like there should be a distinction between a 'module' and a 'namespace', perhaps a namespace maintains a collection of modules. Dunno. This is working for now.