-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement docstrings #267
Implement docstrings #267
Conversation
fddca66
to
ae2e851
Compare
This looks really good -- I think, for the sake of @leviathanbeak's sanity and usability, we should probably remove the cc @leviathanbeak -- what do you think about this for |
Wouldn't that result in information loss? There's cases where documentation should be in different lines (e.g. there's an inline code block). |
We could keep newline characters, my meaning is just to not keep them as separate items in an array. |
@sezna yeah makes sense, no need to keep the "///" just for me to clean them up - while having separate (new)lines makes sense as well. nice job @emilyaherbert |
|
Could we still do this? Just a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with nits if you want to take them
Closes #149
For the test case:
It produces
vec
:It doesn't actually do anything with the
vec
, it just kind of keeps it around for now. I suppose implementing something with it will be a seperate issue.