Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into the "Replace swayfmt PR" with fixes for excess newlines #2695

Closed
wants to merge 4 commits into from

Conversation

mitchmindtree
Copy link
Contributor

@mitchmindtree mitchmindtree commented Sep 2, 2022

This PR is against @eureka-cpu's awesome work in #2669. It aims to merge in master, resolving some conflicts showing up since landing #2692 (curiously, these conflicts didn't show up locally).

kayagokalp and others added 4 commits September 2, 2022 07:57
Co-authored-by: Toby Hutton <toby@grusly.com>
* newline handler checks for existing newlines before inserting new ones

* stability test added

* newline-comment handler interaction test added

* review suggestion
@mitchmindtree
Copy link
Contributor Author

mitchmindtree commented Sep 2, 2022

Going to close this as it looks like we haven't quite solved #2691 as the examples are still showing some issues. Will add more details to #2669 #2691.

@eureka-cpu
Copy link
Contributor

Going to close this as it looks like we haven't quite solved #2691 as the examples are still showing some issues. Will add more details to #2669.

Should I re-open #2691 ?

@mitchmindtree
Copy link
Contributor Author

Should I re-open #2691 ?

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants