Implement forc doc
#2869
Merged
Implement forc doc
#2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eureka-cpu
added
enhancement
eureka-cpu
requested review from
emilyaherbert,
mohammadfawaz,
JoshuaBatty,
kayagokalp and
mitchmindtree
JoshuaBatty
previously approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Great work @eureka-cpu ! The code looks super clean and readable. Happy for this to land as is and follow-up PR's be made iteratively to finish off the missing functionality.
|
Agh, looks like there was a version bump while I was reviewing this. I might take the liberty of pushing the dep updates for this PR so we can get CI working again since I believe you're on holidays now. |
JoshuaBatty
previously approved these changes
Oct 25, 2022
forc-plugins/forc-doc/Cargo.toml
Outdated
| @@ -0,0 +1,20 @@ | |||
| [package] | |||
| name = "forc-doc" | |||
| version = "0.1.0" | |||
There was a problem hiding this comment.
Should this be 0.28.1?
There was a problem hiding this comment.
Yes, yes it should :) Good catch
mohammadfawaz
approved these changes
Oct 25, 2022
JoshuaBatty
approved these changes
Oct 25, 2022
|
Thanks for handling that for me @JoshuaBatty ! |
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening up for visibility, still reading throughcargo docand previous comments related to thisCloses #161
enum variantattributes toTyProgram#3027constattributes toTyProgram#3033traitattributes toTyProgram#3036abiattributes toTyProgram#3038spanfield toconstforforc doc#3088spanfield totraitforforc doc#3090