Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing docstrings before method decls in ABIs #289

Merged
merged 3 commits into from
Oct 3, 2021
Merged

Implementing docstrings before method decls in ABIs #289

merged 3 commits into from
Oct 3, 2021

Conversation

emilyaherbert
Copy link
Contributor

Closes #284

@emilyaherbert emilyaherbert added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged labels Oct 1, 2021
@emilyaherbert emilyaherbert self-assigned this Oct 1, 2021
@emilyaherbert emilyaherbert changed the title parsing Implementing docstrings before method decls in ABIs Oct 1, 2021
@emilyaherbert emilyaherbert marked this pull request as ready for review October 1, 2021 16:42
@emilyaherbert emilyaherbert requested review from sezna and otrho October 1, 2021 16:42
@emilyaherbert emilyaherbert merged commit f83dd8c into master Oct 3, 2021
@emilyaherbert emilyaherbert deleted the emilyaherbert-284/docstring-before-method-decl-in-abi branch October 3, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otrho otrho otrho approved these changes

@sezna sezna Awaiting requested review from sezna

Assignees

@emilyaherbert emilyaherbert

Labels
bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docstring before method decl in ABI throws error
2 participants
@emilyaherbert @otrho