Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DeclRef for struct and enum TypeInfo #4213

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Use DeclRef for struct and enum TypeInfo #4213

merged 1 commit into from
Mar 3, 2023

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented Mar 2, 2023 •
edited
Loading

Description

Use references and the decl engine to resolve information about structs and enums instead of copying around declaration data.

This should facilitate #3744

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 added enhancement New feature or request code quality compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Mar 2, 2023
@IGI-111 IGI-111 self-assigned this Mar 2, 2023
@emilyaherbert
Copy link
Contributor

Thanks @IGI-111! Awesome work on this.

@emilyaherbert
Copy link
Contributor

CC @eureka-cpu, this PR should unblock you.

@emilyaherbert emilyaherbert mentioned this pull request Mar 3, 2023
Closed
@IGI-111 IGI-111 force-pushed the IGI-111/use-declref-for-enum-and-struct branch 4 times, most recently from c86053f to d6638f7 Compare March 3, 2023 04:40
@IGI-111 IGI-111 force-pushed the IGI-111/use-declref-for-enum-and-struct branch 6 times, most recently from bd4e373 to 992f7fd Compare March 3, 2023 10:04
@IGI-111 IGI-111 marked this pull request as ready for review March 3, 2023 10:35
@IGI-111 IGI-111 requested a review from a team March 3, 2023 10:36
tritao
tritao previously approved these changes Mar 3, 2023
View reviewed changes
@IGI-111
Use DeclRef for struct and enum TypeInfo
ccb04f5 
Use references and the decl engine to resolve information about structs
and enums instead of copying around declaration data.

This should facilitate #3744
@IGI-111 IGI-111 force-pushed the IGI-111/use-declref-for-enum-and-struct branch from 992f7fd to ccb04f5 Compare March 3, 2023 11:18
@IGI-111 IGI-111 requested review from tritao and a team March 3, 2023 11:19
@IGI-111 IGI-111 requested a review from a team March 3, 2023 13:02
@IGI-111 IGI-111 merged commit 8be626a into master Mar 3, 2023
@IGI-111 IGI-111 deleted the IGI-111/use-declref-for-enum-and-struct branch March 3, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eureka-cpu eureka-cpu eureka-cpu left review comments

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

@tritao tritao tritao approved these changes

Assignees

@IGI-111 IGI-111

Labels
code quality compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IGI-111 @emilyaherbert @tritao @eureka-cpu @mohammadfawaz