Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sway Ref: Style guide unused variables #4660

Merged
merged 6 commits into from
Jul 17, 2023
Merged

Sway Ref: Style guide unused variables #4660

merged 6 commits into from
Jul 17, 2023

Conversation

Braqzen
Copy link
Contributor

@Braqzen Braqzen commented Jun 13, 2023

Description

Closes #4656

Added getters to forc workspace because it wasn't in there for some reason.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Braqzen Braqzen added the The Sway Reference Everything to do with the Sway Reference label Jun 13, 2023
@Braqzen Braqzen requested review from a team June 13, 2023 14:15
@Braqzen Braqzen self-assigned this Jun 13, 2023
@Braqzen Braqzen marked this pull request as ready for review June 13, 2023 14:25
@Braqzen Braqzen enabled auto-merge (squash) June 13, 2023 14:26
@IGI-111 IGI-111 requested a review from a team June 13, 2023 16:11
@Braqzen Braqzen requested a review from IGI-111 June 13, 2023 19:21
K1-R1
K1-R1 previously approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@K1-R1 K1-R1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New docs content looks good, but the git dependency path in docs/reference/src/code/Forc.lock is odd

@anton-trunov
Copy link
Contributor

LGTM too, modulo the git dep thing

anton-trunov
anton-trunov previously approved these changes Jul 13, 2023
View reviewed changes
@Braqzen Braqzen dismissed stale reviews from anton-trunov and K1-R1 via 24b08cb July 13, 2023 16:58
@Braqzen Braqzen requested review from K1-R1, anton-trunov and tritao July 13, 2023 17:03
@Braqzen Braqzen merged commit 7d77490 into master Jul 17, 2023
@Braqzen Braqzen deleted the braqzen-4656 branch July 17, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1-R1 K1-R1 K1-R1 approved these changes

@anton-trunov anton-trunov anton-trunov approved these changes

@IGI-111 IGI-111 Awaiting requested review from IGI-111

@tritao tritao Awaiting requested review from tritao

Assignees

@Braqzen Braqzen

Labels
The Sway Reference Everything to do with the Sway Reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sway Ref: Style guide unused variables
5 participants
@Braqzen @anton-trunov @tritao @IGI-111 @K1-R1