Adds Hash trait and Hasher struct to std lib. #4701

esdrubal · 2023-06-22T16:39:14Z

Description

Implements Hash trait for builtin types and for some std lib types.

This is required to have a proper hashing that does not change in case the internal memory representation of type changes.

Current hashing functions are hashing the types in memory directly, as this representation might change in future versions of the VM and compiler we want to have a more reliable way of getting hashes that won't change in future versions of the compiler and std lib.

Replaces use of sha256 function with Hasher in storage_map and storage_vec.

Adds intrinsic __check_str_type.

__check_str_type returns an error at compile time in case the provided generic type is not a str.

This is used to guarantee that Hasher write_str is not called with non str types.

Closes #3835.

Checklist

I have linked to any relevant issues.
I have commented my code, particularly in hard-to-understand areas.
I have updated the documentation where relevant (API docs, the reference, and the Sway book).
I have added tests that prove my fix is effective or that my feature works.
I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
I have requested a review from the relevant team or maintainers.

We were not calling replace_decl for variable declarations. This was making some trait method calls to not be replaced. Unblocks #4701 Fixes #4773

## Description We were not calling replace_decl for variable declarations. This was making some trait method calls to not be replaced. Unblocks #4701 Fixes #4773 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.

examples/hashing/src/main.sw

sway-lib-std/src/storage/storable_slice.sw

sway-lib-std/src/storage/storage_map.sw

sway-lib-std/src/storage/storage_vec.sw

test/src/sdk-harness/test_projects/storage_map/src/main.sw

test/src/sdk-harness/test_projects/script_bytecode/src/main.sw

test/src/e2e_vm_tests/test_programs/should_pass/stdlib/option/src/data_structures.sw

test/src/e2e_vm_tests/test_programs/should_pass/stdlib/option/src/tests.sw

sway-lib-std/src/address.sw

The issue this commit solves is the method not found error thrown when when we try to use generic traits. This issue was fixed by adding support to the `unify_check` so left types can match right types `UnknownGeneric`. We also check that the left type implemnts the trait constraints of the `UnknownGeneric` before return true. Fixes #4806 Unblocks #4701

The issue this commit solves is the method not found error thrown when we try to use generic traits. This issue was fixed by calling `insert_trait_implementation_for_type` while resolving tuples and arrays, we also call `insert_trait_implementation_for_type` as a fail safe when a method is not found. Fixes #4806 Unblocks #4701

## Description The issue this commit solves is the method not found error thrown when we try to use generic traits. This issue was fixed by calling `insert_trait_implementation_for_type` while resolving tuples and arrays, we also call `insert_trait_implementation_for_type` as a fail-safe when a method is not found. Fixes #4806 Unblocks #4701 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. Co-authored-by: Anton Trunov <anton.a.trunov@gmail.com>

anton-trunov · 2023-07-26T09:30:50Z

I'm wondering if this issue #3835 is related. Should it be closed after this PR is merged?

IGI-111 · 2023-07-26T09:40:47Z

It should, yeah.

Implements Hash trait for builtin types and for some std lib types. This is required to have a proper hashing that does not change in case the internal memory representation of type changes. Current hashing functions are hashing the types in memory directly, as this representation might change in future versions of the VM and compiler we want to have a more reliable way of getting hashes that won't change in future versions of the compiler and std lib. Replaces use of sha256 function with Hasher in storage_map and storage_vec. Adds intrinsic __check_str_type. __check_str_type returns an error at compile time in case the provided generic type is not a str. This is used to guarantee that `Hasher` `write_str` is not called with non str types.

esdrubal · 2023-08-17T08:43:39Z

The PR is finally green, all review requests were addressed. Ready for review again.

sway-core/src/semantic_analysis/namespace/trait_map.rs

IGI-111 · 2023-08-17T18:18:44Z

Small nit but LGTM

esdrubal added the lib: std Standard library label Jun 22, 2023

esdrubal self-assigned this Jun 22, 2023

esdrubal force-pushed the esdrubal/hash branch from 581cd6b to 866730b Compare June 27, 2023 10:53

IGI-111 added this to the October 2023 milestone Jul 6, 2023

esdrubal added a commit that referenced this pull request Jul 7, 2023

Fixes missing replace_decl for variable declarations.

4a93025

We were not calling replace_decl for variable declarations. This was making some trait method calls to not be replaced. Unblocks #4701 Fixes #4773

esdrubal mentioned this pull request Jul 7, 2023

Fixes missing replace_decl for variable declarations. #4777

Merged

7 tasks

esdrubal force-pushed the esdrubal/hash branch 3 times, most recently from b5eb0b6 to 542c84a Compare July 10, 2023 14:22

esdrubal added the breaking May cause existing user code to break. Requires a minor or major release. label Jul 10, 2023

esdrubal requested a review from a team July 10, 2023 14:44

esdrubal marked this pull request as ready for review July 10, 2023 14:44