chore: add forc-pkg codeowner #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
approved these changes
Jul 17, 2023
anton-trunov
approved these changes
Jul 18, 2023
eureka-cpu
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We will be fixing #4709, but the one thing more important than fixing it might be ensuring that it does not happen again. Until we have the bandwidth to introduce nice CLI testing suite I am adding myself as code owner to forc-pkg. Since forc-pkg lives between the compiler and forc, it is seeing lots of traffic and I will try to make sure nothing changes in terms of user experience during those changes. Feel free to close this, if you feel like we might have a better way of ensuring this before we got the CLI testing suite ready.