Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct usage of terms "ABI" and "JSON ABI" #4847

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

AlicanC
Copy link
Contributor

@AlicanC AlicanC commented Jul 21, 2023

This PR clears up usage of terms "ABI" (our actual ABI) and "JSON ABI" (the JSON representation of our ABI).

What we really actually have here is the "Rust ABI" but we can drop the "Rust" and just call it "ABI".

Other ABIs would be the "TypeScript ABI" generated by fuels-ts, and the "GraphQL ABI" I'm planning to work on.

@AlicanC AlicanC marked this pull request as ready for review July 21, 2023 16:12
@AlicanC AlicanC requested a review from kayagokalp as a code owner July 21, 2023 16:12
@AlicanC AlicanC self-assigned this Jul 21, 2023
@AlicanC AlicanC requested review from a team July 21, 2023 16:12
@AlicanC AlicanC enabled auto-merge (squash) July 21, 2023 16:13
@AlicanC AlicanC added code quality ABI Everything to do the ABI, especially the JSON representation labels Jul 21, 2023
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! forc-pkg changes seems good to me.

@kayagokalp kayagokalp requested a review from a team July 24, 2023 09:43
@AlicanC AlicanC merged commit b19174a into master Jul 24, 2023
@AlicanC AlicanC deleted the jc/abi-code-naming branch July 24, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABI Everything to do the ABI, especially the JSON representation code quality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants