Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused keys from examples under sway repo reference #4854

Merged
merged 5 commits into from
Jul 26, 2023

Conversation

gr00vytvniks
Copy link
Contributor

@gr00vytvniks gr00vytvniks commented Jul 24, 2023

Description

This PR removes unused keys in sway reference so that warnings do not appear while searching for std after creating a new project with forc init.

Closes #4709

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

@gr00vytvniks
Copy link
Contributor Author

@JoshuaBatty

Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gr00vytvniks, thanks for the PR! Looks nice :) Let's remove those lines instead of commenting them. I haven't test this yet, but to test it you can basically add a std dependency to your project with git source pointing to this branch.

After removing those lines I'll test it locally 👌

@kayagokalp kayagokalp added code quality forc-pkg Everything related to the `forc-pkg` crate. The Sway Reference Everything to do with the Sway Reference labels Jul 24, 2023
@kayagokalp kayagokalp removed the forc-pkg Everything related to the `forc-pkg` crate. label Jul 26, 2023
@kayagokalp kayagokalp marked this pull request as ready for review July 26, 2023 12:10
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and warnings are gone,

 Compiling library core (/Users/kayagokalp/.forc/git/checkouts/std-7556e1648bbdb2a4/f8573a6e36d7bd036bd7406a17e0af2852fbde5b/sway-lib-core)
 Compiling library std (git+https://github.com/gr00vytvniks/sway?branch=gr00vytvniks/rm-unused-deps#f8573a6e36d7bd036bd7406a17e0af2852fbde5b)
 Compiling contract test_duplicate_warnings (/Users/kayagokalp/fuel/test_projects/test_duplicate_warnings)
  Finished debug in 4.008801375s
  contract test_duplicate_warnings
      Bytecode size: 68 bytes
[project]
authors = ["kayagokalp"]
entry = "main.sw"
license = "Apache-2.0"
name = "test_duplicate_warnings"
implicit-std = false

[dependencies]
std = { git = "https://github.com/gr00vytvniks/sway", branch = "gr00vytvniks/rm-unused-deps" }

@kayagokalp kayagokalp requested a review from JoshuaBatty July 26, 2023 12:22
@kayagokalp kayagokalp enabled auto-merge (squash) July 26, 2023 12:23
@kayagokalp kayagokalp changed the title Chore: Remove unused dependencies from new projects created by forc init chore: remove unused keys from examples under sway repo reference Jul 26, 2023
@kayagokalp kayagokalp disabled auto-merge July 26, 2023 12:25
@kayagokalp kayagokalp enabled auto-merge (squash) July 26, 2023 12:26
@kayagokalp kayagokalp requested a review from a team July 26, 2023 12:26
Copy link
Contributor

@eureka-cpu eureka-cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@kayagokalp kayagokalp merged commit 2bb0724 into FuelLabs:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality The Sway Reference Everything to do with the Sway Reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lots of warnings on forc init -> forc test, considering cleanup
5 participants