-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused keys from examples under sway repo reference #4854
chore: remove unused keys from examples under sway repo reference #4854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gr00vytvniks, thanks for the PR! Looks nice :) Let's remove those lines instead of commenting them. I haven't test this yet, but to test it you can basically add a std
dependency to your project with git source pointing to this branch.
After removing those lines I'll test it locally 👌
docs/reference/src/code/language/program-types/contracts/wallet/Forc.toml
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_fail/conditional_compilation/bad_target/Forc.toml
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_fail/conditional_compilation/no_target/Forc.toml
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_pass/conditional_compilation/compile/Forc.toml
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_pass/conditional_compilation/run/Forc.toml
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_pass/evm/evm_basic/Forc.toml
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_pass/midenvm/midenvm_trivial/Forc.toml
Outdated
Show resolved
Hide resolved
docs/reference/src/code/language/program-types/contracts/wallet/Forc.toml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and warnings are gone,
Compiling library core (/Users/kayagokalp/.forc/git/checkouts/std-7556e1648bbdb2a4/f8573a6e36d7bd036bd7406a17e0af2852fbde5b/sway-lib-core)
Compiling library std (git+https://github.com/gr00vytvniks/sway?branch=gr00vytvniks/rm-unused-deps#f8573a6e36d7bd036bd7406a17e0af2852fbde5b)
Compiling contract test_duplicate_warnings (/Users/kayagokalp/fuel/test_projects/test_duplicate_warnings)
Finished debug in 4.008801375s
contract test_duplicate_warnings
Bytecode size: 68 bytes
[project]
authors = ["kayagokalp"]
entry = "main.sw"
license = "Apache-2.0"
name = "test_duplicate_warnings"
implicit-std = false
[dependencies]
std = { git = "https://github.com/gr00vytvniks/sway", branch = "gr00vytvniks/rm-unused-deps" }
forc init
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Description
This PR removes unused keys in sway reference so that warnings do not appear while searching for std after creating a new project with
forc init
.Closes #4709
Checklist
Breaking*
orNew Feature
labels where relevant.