Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update std-lib cryptographic functions to meet SRC-2 inline docs standard #4863

Merged
merged 6 commits into from
Aug 5, 2023
Merged

Update std-lib cryptographic functions to meet SRC-2 inline docs standard #4863

merged 6 commits into from
Aug 5, 2023

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Jul 25, 2023 •
edited
Loading

Description

This PR completes the erc.sw, hash.sw, message.sw, evm/erc.sw, and evm/evm_address.sw tasks of #4812

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic added lib: std Standard library documentation labels Jul 25, 2023
@bitzoic bitzoic requested a review from SwayStar123 July 25, 2023 10:47
@bitzoic bitzoic self-assigned this Jul 25, 2023
SwayStar123
SwayStar123 requested changes Jul 26, 2023
View reviewed changes
sway-lib-std/src/ecr.sw Show resolved Hide resolved
sway-lib-std/src/ecr.sw Show resolved Hide resolved
sway-lib-std/src/vm/evm/ecr.sw Show resolved Hide resolved
@bitzoic bitzoic requested a review from SwayStar123 August 4, 2023 14:49
@SwayStar123
Copy link
Member

Tests broken for some reason

@bitzoic
Copy link
Member Author

bitzoic commented Aug 4, 2023

Tests broken for some reason

Just need to merge in the standard-documentation branch

@bitzoic bitzoic merged commit 3462264 into standard-documentation Aug 5, 2023
@bitzoic bitzoic deleted the bitzoic-crypto-docs branch August 5, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwayStar123 SwayStar123 SwayStar123 approved these changes

Assignees

@bitzoic bitzoic

Labels
documentation lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitzoic @SwayStar123