-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
u256 more operations #4904
Merged
Merged
u256 more operations #4904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunilrj
force-pushed
the
xunilrj/u256-more-operations
branch
from
August 4, 2023 08:25
8e4b98b
to
a3a3abc
Compare
IGI-111
reviewed
Aug 4, 2023
IGI-111
reviewed
Aug 4, 2023
Just some nitpicks, otherwise LGTM |
We need IR parsing tests for the new IR opcodes (for this and the recently introduced ones too). I'm guessing that they can go into Otherwise LGTM. |
Done. |
vaivaswatha
approved these changes
Aug 7, 2023
IGI-111
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of #4794 and implements more operators for u256:
Checklist
Breaking*
orNew Feature
labels where relevant.