Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u256 more operations #4904

Merged
merged 13 commits into from
Aug 7, 2023
Merged

u256 more operations #4904

merged 13 commits into from
Aug 7, 2023

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Aug 3, 2023

Description

This PR is part of #4794 and implements more operators for u256:

  • sub
  • mul
  • div
  • comparisions
  • mod

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj self-assigned this Aug 3, 2023
@xunilrj xunilrj mentioned this pull request Aug 3, 2023
19 tasks
@xunilrj xunilrj force-pushed the xunilrj/u256-more-operations branch from 8e4b98b to a3a3abc Compare August 4, 2023 08:25
@xunilrj xunilrj marked this pull request as ready for review August 4, 2023 13:16
@xunilrj xunilrj requested a review from a team August 4, 2023 14:17
@IGI-111
Copy link
Contributor

IGI-111 commented Aug 4, 2023

Just some nitpicks, otherwise LGTM

@vaivaswatha
Copy link
Contributor

vaivaswatha commented Aug 7, 2023

We need IR parsing tests for the new IR opcodes (for this and the recently introduced ones too). I'm guessing that they can go into sway-ir/tests/serialize.

Otherwise LGTM.

@xunilrj
Copy link
Contributor Author

xunilrj commented Aug 7, 2023

We need IR parsing tests for the new IR opcodes (for this and the recently introduced ones too). I'm guessing that they can go into sway-ir/tests/serialize.

Done.

@xunilrj xunilrj enabled auto-merge (squash) August 7, 2023 07:19
@xunilrj xunilrj requested review from IGI-111 and a team August 7, 2023 07:20
@xunilrj xunilrj merged commit 943c67c into master Aug 7, 2023
@xunilrj xunilrj deleted the xunilrj/u256-more-operations branch August 7, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants