-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate deployment artifacts with forc-deploy #4913
Conversation
Nice work, this will be super handy for users. The code looks good. Would you mind also adding this to the docs, maybe showing the example of an generated artifacts and some information about where the json is saved etc..? |
Added docs with example artifact, should be good to go! |
Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
closes #4744.
This PR adds deployment artifact serialization to forc-deploy. Basically each deployment info is saved as a json file in the out folder. So that users wont lose precious deployment information after closing their terminal.
An example deployment artifact can be seen below:
Since serde serialization for
ContarctId
and other deployment related client/vm primitives do not emit 0x at the beginning i had to convert them toString
s 0x prefixed. I feel like we can change human readable serialization to include 0x to all hex fields.Checklist
Breaking*
orNew Feature
labels where relevant.