Refactor parse_project
to return a result.
#4922
Merged
+218
−213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
parse_project
method to return a result instead of writing to internal types in place. This helps to seperate the parsing and writing logic into seperate phases, useful for future work where we execute parsing on seperate threads.I've also tried to clean up the
Session
interface at the same time.Checklist
Breaking*
orNew Feature
labels where relevant.