Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parse_project to return a result. #4922

Merged
merged 9 commits into from
Aug 7, 2023

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Aug 7, 2023

Description

This PR refactors the parse_project method to return a result instead of writing to internal types in place. This helps to seperate the parsing and writing logic into seperate phases, useful for future work where we execute parsing on seperate threads.

I've also tried to clean up the Session interface at the same time.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Sorry, something went wrong.

@JoshuaBatty JoshuaBatty self-assigned this Aug 7, 2023
@JoshuaBatty JoshuaBatty requested review from a team August 7, 2023 03:11
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cleaner! utACK

@kayagokalp kayagokalp requested a review from a team August 7, 2023 10:49
@IGI-111 IGI-111 requested a review from a team August 7, 2023 11:02
@JoshuaBatty JoshuaBatty merged commit 227cb2b into master Aug 7, 2023
@JoshuaBatty JoshuaBatty deleted the josh/refactor_parse_project branch August 7, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants