Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

u256 bitwise and comparison operators #4947

Merged
merged 7 commits into from
Aug 30, 2023
Merged

u256 bitwise and comparison operators #4947

merged 7 commits into from
Aug 30, 2023

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Aug 14, 2023 •
edited
Loading

Description

This PR is part of #4794. It implements the missing operators: bitwise and comparison.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj self-assigned this Aug 14, 2023
@xunilrj xunilrj mentioned this pull request Aug 14, 2023
Closed
19 tasks
IGI-111
IGI-111 previously approved these changes Aug 16, 2023
View reviewed changes
@IGI-111 IGI-111 requested a review from a team August 16, 2023 10:24
@xunilrj xunilrj requested review from anton-trunov and a team and removed request for anton-trunov and a team August 17, 2023 11:53
@xunilrj xunilrj force-pushed the xunilrj/u256-bitwise-and-comparison-operators branch from 3acdc88 to 1b5f897 Compare August 17, 2023 12:33
@IGI-111
Copy link
Contributor

IGI-111 commented Aug 18, 2023

Could these intrinsics also be used for b256? Arithmetic doesn't make sense on that one but bitwise operations do, and it would make them const-evaluable.

@xunilrj
Copy link
Contributor Author

xunilrj commented Aug 18, 2023

Could these intrinsics also be used for b256? Arithmetic doesn't make sense on that one but bitwise operations do, and it would make them const-evaluable.

I don´t see why not. I will extend #4794 to also support bitwise for b256.

@xunilrj xunilrj force-pushed the xunilrj/u256-bitwise-and-comparison-operators branch 2 times, most recently from 7d6cdbd to 1123812 Compare August 21, 2023 06:35
@xunilrj xunilrj force-pushed the xunilrj/u256-bitwise-and-comparison-operators branch from 1123812 to 7825df8 Compare August 22, 2023 08:20
@xunilrj xunilrj requested a review from IGI-111 August 22, 2023 09:40
IGI-111
IGI-111 previously approved these changes Aug 23, 2023
View reviewed changes
@xunilrj xunilrj force-pushed the xunilrj/u256-bitwise-and-comparison-operators branch from cf0010b to 2439cea Compare August 28, 2023 09:00
@xunilrj xunilrj force-pushed the xunilrj/u256-bitwise-and-comparison-operators branch from 2439cea to d3181a1 Compare August 28, 2023 10:34
@xunilrj xunilrj force-pushed the xunilrj/u256-bitwise-and-comparison-operators branch from d3181a1 to 65bc629 Compare August 28, 2023 11:39
@xunilrj xunilrj requested a review from IGI-111 August 28, 2023 12:36
@IGI-111 IGI-111 requested a review from a team August 29, 2023 09:51
@xunilrj xunilrj requested review from anton-trunov, vaivaswatha, tritao and esdrubal and removed request for anton-trunov August 29, 2023 10:45
@xunilrj xunilrj merged commit e1d0ea0 into master Aug 30, 2023
@xunilrj xunilrj deleted the xunilrj/u256-bitwise-and-comparison-operators branch August 30, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@anton-trunov anton-trunov anton-trunov approved these changes

@SwayStar123 SwayStar123 Awaiting requested review from SwayStar123

@vaivaswatha vaivaswatha Awaiting requested review from vaivaswatha

@tritao tritao Awaiting requested review from tritao

@esdrubal esdrubal Awaiting requested review from esdrubal

Assignees

@xunilrj xunilrj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xunilrj @IGI-111 @anton-trunov