Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message for doc comment without an item #4970

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Aug 17, 2023

Description

This PR closes #4968. The problem here is that doc comments are special in the sense that they demand an item after.

I am following the rustc error message of my machine, but rust playground message is a little different. Not sure which way we want to go.

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=34097e067111a355e70767be7965952c

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj requested a review from a team August 17, 2023 10:22
@xunilrj xunilrj self-assigned this Aug 17, 2023
@IGI-111 IGI-111 requested a review from a team August 17, 2023 19:37
@xunilrj xunilrj force-pushed the xunirj/fix-doc-comment-without-item branch from 0d87479 to 216ab50 Compare August 18, 2023 07:25
@xunilrj xunilrj merged commit 2506a26 into master Aug 18, 2023
@xunilrj xunilrj deleted the xunirj/fix-doc-comment-without-item branch August 18, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser error on doc comments
3 participants