-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser recovery inside trait/abi #4979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunilrj
changed the title
Parser recovery inside trait
Parser recovery inside trait/abi
Aug 21, 2023
xunilrj
force-pushed
the
xunilrj/parser-recovery-inside-trait
branch
from
August 22, 2023 08:20
0fadddb
to
9bf4029
Compare
JoshuaBatty
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, seems like a reasonable approach.
tritao
approved these changes
Aug 23, 2023
xunilrj
force-pushed
the
xunilrj/parser-recovery-inside-trait
branch
from
August 23, 2023 14:05
ecef273
to
5e78494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4729.
The trick part of this PR is that
TraitItems
were being parsed as(TraitItem, SemicolonToken)
. The problem is that to recover from an error we call theerror
method of theParser
trait. And it is very hard to come up with a generic implementation for the tuple. Which type of tuple do we call itserror
method, and how do we return a valid tuple in all cases? Impossible.So that is why I moved the
SemicolonToken
to inside theTraitItem
. Another benefit is that we can recover from missing semicolons with nice error messages.Checklist
Breaking*
orNew Feature
labels where relevant.