-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beta-4 target to forc, refactor with tests, and UX improvements #4991
Conversation
Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good 🙌 Thanks a lot for the help :) Just a single change requested so that we can deploy with forc-deploy --testnet
Ahh looks like FuelLabs/sway-libs#185 changed folder structure in sway-libs. Fixing it in a separate PR. |
Fix: #4998 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) waiting docs fix to merge so that CI unblocks: #4998
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Closes #4974
Added the beta-4 target and updated documentation (from #4974)
Refactored part of forc-deploy and added unit tests.
Gas
are now optional, so we only override them when the user hasn't specified anythingOther changes:
/graphql
prefixes, so I updated the constants to remove the prefix. This is shown to the user and it looks cleaner without it.deploy
,run
, andsubmit
all now have the same options for specifying the node (node_url, testnet, and target), capture in theTargetNode
struct. They use the same helper functions to extract the node url and determine gas limit & price.Checklist
Breaking*
orNew Feature
labels where relevant.