Remove extra insert_trait_implementation_for_type #5004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type resolution function calls this function at a later stage, hence this one is not needed. This makes trait map sizes smaller and saves a bunch of type ids. Partially resolves issue #5002
anton-trunov
added
the
compiler: frontend
tritao
approved these changes
Aug 23, 2023
…lementation_for_type
JoshuaBatty
approved these changes
Aug 23, 2023
anton-trunov
deleted the
anton-trunov/remove-extra-insert_trait_implementation_for_type
branch
30 tasks
anton-trunov
added a commit
that referenced
this pull request
Oct 3, 2023
## Description Fixes #4877 ## Tasks - [x] Make a simple example with a trait and an impl for it compile - [x] Fix typechecking for empty enums - [x] Fix typechecking for trait impl methods - [x] Fix typechecking for impl self blocks - [x] Fix the case of non-implemented supertraits - [x] Fix typechecking of generic traits - [x] Fix typechecking of generic impl self blocks - [x] Resolve ambiguity between term/path-level `Self` and the type-level `Self` type parameter (related PR #4459): - [x] enums - [x] structs (deferred as issue #5164) - [x] Fix `Self` for type constraints - [x] Fix looping during insertion of trait constraints for generic tuples (inserted `occurs_check` to prevent unification of a generic `A` with a tuple `(A, A)`; - [x] Fix exponential growth of the traits map (around 30 tests out of more than 680 are failing now); related PR: #5004 - [x] Fix `Self` type for blanket implementations - [x] Fix `Self` for associated consts - [x] Fix name resolution issues for some tests with traits (like `should_pass/language/eq_intrinsic`); blocking issues: - #5018 - #5036 - [x] Fix `should_fail/generic_traits` test - [x] Fix `should_pass/language/where_clause_impls` test - [x] Fix `should_pass/language/name_resolution_inside_intrinsics` test - [x] Remove some commented out code in `impl_trait.rs` - [x] Comment new code - [x] **Disable** `should_pass/language/associated_type_container` test - [x] **Disable** `should_pass/language/associated_type_method` test - [x] **Disable** `should_pass/language/associated_type_and_associated_const` test - [x] **Disable** `should_pass/language/associated_type_iterator` test ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: Joshua Batty <joshpbatty@gmail.com> Co-authored-by: IGI-111 <igi-111@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type resolution function calls this function at a later stage, hence this one is not needed.
This makes trait map sizes smaller and saves a bunch of type ids.
Partially resolves issue #5002
Description
Checklist
Breaking*orNew Featurelabels where relevant.