Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Don't recompile workspace when moving between files #5032

Merged
merged 6 commits into from
Aug 25, 2023
Merged

LSP: Don't recompile workspace when moving between files #5032

merged 6 commits into from
Aug 25, 2023

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Aug 25, 2023 •
edited
Loading

Description

We have been unnecessarily recompiling the whole workspace when a user moves between different files. As the whole workspace is already compiled and traversed this was hugely unnecessary. Feels so much nicer moving between files now.

closes #5031

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty self-assigned this Aug 25, 2023
@JoshuaBatty JoshuaBatty added the language server LSP server label Aug 25, 2023
@JoshuaBatty JoshuaBatty requested review from a team August 25, 2023 01:54
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) August 25, 2023 01:54
kayagokalp
kayagokalp approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@JoshuaBatty JoshuaBatty merged commit 15e0ec4 into master Aug 25, 2023
@JoshuaBatty JoshuaBatty deleted the josh/did_open branch August 25, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayagokalp kayagokalp kayagokalp approved these changes

@tritao tritao tritao approved these changes

Assignees

@JoshuaBatty JoshuaBatty

Labels
language server LSP server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSP shouldn't recompile when moving between rust files in the users workspace
3 participants
@JoshuaBatty @tritao @kayagokalp