Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eq implementation for String #5055

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Add Eq implementation for String #5055

merged 2 commits into from
Aug 30, 2023

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Aug 29, 2023

Description

The Eq implementation seems to have been missing since moving the String type from sway-libs to the standard library.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic requested review from IGI-111 and a team August 29, 2023 12:33
@bitzoic bitzoic self-assigned this Aug 29, 2023
@bitzoic bitzoic added bug Something isn't working lib: std Standard library labels Aug 29, 2023
@bitzoic bitzoic enabled auto-merge (squash) August 30, 2023 05:53
@bitzoic bitzoic merged commit 2d10293 into master Aug 30, 2023
@bitzoic bitzoic deleted the bitzoic-eq-string branch August 30, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants