Accumulate typechecking methods in impl TypeCheckContext, part 2
#5088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the `impl TypeEngine` methods from the file `type_system/engine.rs` that also take `Engines` and `Namespace` as parameters have been moved into `impl TypeCheckContext`. All the `impl Root` methods from the file `namespace/root.rs` that also take `Engines` as parameters have been moved into `impl TypeCheckContext`. I'm splitting the refactoring into several PRs to solicit early feedback, make review process a bit easier and potentially create fewer merge conflicts. List of changes: - `type_engine.monomorphize` -> `ctx.monomorphize_with_modpath` - `type_engine.resolve` -> `ctx.resolve` - `type_engine.resolve_with_self` -> `ctx.resolve_with_self` - `type_engine.MonomorphizeHelper` -> `ctx.MonomorphizeHelper` - `type_engine.EnforceTypeArguments` -> `ctx.EnforceTypeArguments` - `namespace.root.resolve_call_path_with_visibility_check` -> `ctx.resolve_call_path_with_visibility_check_and_modpath`
anton-trunov
added
the
compiler: frontend
anton-trunov
changed the title
impl TypeCheckContext, part 2
|
I'll check if this PR is already enough to resolve issue #5036. If it is, I'll stop the refactoring at this point, unless someone has more ideas what else should be moved to |
…rait_implementation_for_type`
tritao
approved these changes
Sep 6, 2023
xunilrj
approved these changes
Sep 6, 2023
anton-trunov
deleted the
anton-trunov/typecheck-context-consolidation-part-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially resolves issue #5050.
All the
impl TypeEnginemethods from the filetype_system/engine.rsthat also takeEnginesandNamespaceas parameters have been moved intoimpl TypeCheckContext.All the
impl Rootmethods from the filenamespace/root.rsthat also takeEnginesas parameters have been moved intoimpl TypeCheckContext.I'm splitting the refactoring into several PRs to solicit early feedback, make review process a bit easier and potentially create fewer merge conflicts.
List of changes:
type_engine.monomorphize->ctx.monomorphize_with_modpathtype_engine.resolve->ctx.resolvetype_engine.resolve_with_self->ctx.resolve_with_selftype_engine.MonomorphizeHelper->ctx.MonomorphizeHelpertype_engine.EnforceTypeArguments->ctx.EnforceTypeArgumentsnamespace.root.resolve_call_path_with_visibility_check->ctx.resolve_call_path_with_visibility_check_and_modpathChecklist
Breaking*orNew Featurelabels where relevant.