-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with variables in match arm alternatives #5104
Merged
ironcev
merged 26 commits into
master
from
ironcev/5081-5082-match-arm-variables-in-alternatives
Sep 22, 2023
Merged
Fix issues with variables in match arm alternatives #5104
ironcev
merged 26 commits into
master
from
ironcev/5081-5082-match-arm-variables-in-alternatives
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR builds on top of #5100 so I'll keep it in draft until that one is closed. |
ironcev
added
bug
Something isn't working
compiler
General compiler. Should eventually become more specific as the issue is triaged
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
compiler: ui
Mostly compiler messages
compiler: static-analysis
labels
Sep 10, 2023
ironcev
changed the title
Ironcev/5081 5082 match arm variables in alternatives
Match arm variables in alternatives
Sep 11, 2023
xunilrj
reviewed
Sep 11, 2023
...src/e2e_vm_tests/test_programs/should_fail/match_expressions_or_mismatched_types/src/main.sw
Show resolved
Hide resolved
Back to draft until decision is made on short-circuiting. |
Back to draft (again 😄 ). I'll put all the remaining work to be done in matcher in this PR. |
ironcev
changed the title
Match arm variables in alternatives
Fix issues with variables in match arm alternatives
Sep 18, 2023
anton-trunov
approved these changes
Sep 20, 2023
...-core/src/semantic_analysis/ast_node/expression/match_expression/typed/typed_match_branch.rs
Show resolved
Hide resolved
tritao
approved these changes
Sep 22, 2023
ironcev
deleted the
ironcev/5081-5082-match-arm-variables-in-alternatives
branch
September 22, 2023 08:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
compiler: static-analysis
compiler: ui
Mostly compiler messages
compiler
General compiler. Should eventually become more specific as the issue is triaged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes three issues related to variables in match arm alternatives:
Closes #5081.
Closes #5082.
Closes #5108.
Demo
Checklist
Breaking*
orNew Feature
labels where relevant.