Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trait interface method name resolution during typechecking of impl #5141

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Fix trait interface method name resolution during typechecking of impl #5141

merged 3 commits into from
Sep 26, 2023

Conversation

anton-trunov
Copy link
Contributor

@anton-trunov anton-trunov commented Sep 24, 2023 •
edited
Loading

Closes #5036

Description

Please see the linked issue

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@anton-trunov anton-trunov added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Sep 24, 2023
@anton-trunov anton-trunov self-assigned this Sep 24, 2023
@anton-trunov anton-trunov marked this pull request as ready for review September 25, 2023 05:28
@anton-trunov anton-trunov requested a review from a team September 25, 2023 05:28
@IGI-111 IGI-111 enabled auto-merge (squash) September 26, 2023 07:19
@IGI-111 IGI-111 merged commit 8b3ed78 into master Sep 26, 2023
@IGI-111 IGI-111 deleted the anton-trunov/fix-name-resolution-after-monomorphization-easy-way branch September 26, 2023 08:11
anton-trunov added a commit that referenced this pull request Oct 3, 2023
@anton-trunov
Fix calling trait methods from each other
be15295 
An attempt to fix issue #4770 in the spirit of PR #5141.

Unfotunately (and a bit surprisingly), this fails when compiling stdlib:
```
  Compiling library std (/Users/anton/fuel/sway/sway-lib-std)

  Failed to compile std
  error
     --> /Users/anton/fuel/sway/sway-lib-std/src/hash.sw:322:41
      |
  320 |
  321 | #![inline(never)]
  322 | pub fn sha256<T>(s: T) -> b256 where T: Hash {
      |                                         ^^^^ Could not find symbol "Hash" in this scope.
  323 |     let mut hasher = Hasher::new();
  324 |     s.hash(hasher);
      |
  ____
```
anton-trunov added a commit that referenced this pull request Oct 3, 2023
@anton-trunov
Fix calling trait methods from each other
35e9e42 
An attempt to fix issue #4770 in the spirit of PR #5141.

Unfortunately (and a bit surprisingly), this fails when compiling stdlib:
```
  Compiling library std (/Users/anton/fuel/sway/sway-lib-std)

  Failed to compile std
  error
     --> /Users/anton/fuel/sway/sway-lib-std/src/hash.sw:322:41
      |
  320 |
  321 | #![inline(never)]
  322 | pub fn sha256<T>(s: T) -> b256 where T: Hash {
      |                                         ^^^^ Could not find symbol "Hash" in this scope.
  323 |     let mut hasher = Hasher::new();
  324 |     s.hash(hasher);
      |
  ____
```
anton-trunov added a commit that referenced this pull request Oct 3, 2023
@anton-trunov
Fix calling trait methods from each other
baf17a4 
An attempt to fix issue #4770 in the spirit of PR #5141.

Unfortunately (and a bit surprisingly), this fails when compiling stdlib:
```
  Compiling library std (/Users/anton/fuel/sway/sway-lib-std)

  Failed to compile std
  error
     --> /Users/anton/fuel/sway/sway-lib-std/src/hash.sw:322:41
      |
  320 |
  321 | #![inline(never)]
  322 | pub fn sha256<T>(s: T) -> b256 where T: Hash {
      |                                         ^^^^ Could not find symbol "Hash" in this scope.
  323 |     let mut hasher = Hasher::new();
  324 |     s.hash(hasher);
      |
  ____
```
@anton-trunov anton-trunov mentioned this pull request Oct 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@tritao tritao tritao approved these changes

Assignees

@anton-trunov anton-trunov

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trait name resolution does not work properly in the presence of trait type arguments
3 participants
@anton-trunov @tritao @IGI-111