Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements qualified paths for associated types. #5160

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Implements qualified paths for associated types. #5160

merged 3 commits into from
Oct 13, 2023

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Oct 2, 2023 •
edited
Loading

Description

Adds support for checking if using fully qualified call paths is necessary on associated types disambiguation.

Adds support for specifying fully qualified paths of associated types used in type ascriptions.

Adds support for specifying fully qualified path when calling methods of associated types and when using associated consts of associated types.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal esdrubal force-pushed the esdrubal/associated_types_fully_qualified_types branch from 3e8c833 to 4991fd7 Compare October 2, 2023 12:14
@esdrubal
Implements qualified call paths for associated types.
fd24a80 
Adds support for checking if the usage of fully qualified call paths is
necessary on associated types disambiguation.

Adds support for specifying fully qualified paths of associated types
used in type ascriptions.

As a to-do we still have to support a fully qualified path when calling
methods of associated types and when using associated consts of
associated types.
@esdrubal esdrubal force-pushed the esdrubal/associated_types_fully_qualified_types branch from 4991fd7 to 024d525 Compare October 12, 2023 08:25
@esdrubal esdrubal added compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen enhancement New feature or request labels Oct 12, 2023
@esdrubal esdrubal requested a review from a team October 12, 2023 09:01
@esdrubal esdrubal marked this pull request as ready for review October 12, 2023 09:05
IGI-111
IGI-111 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IGI-111 IGI-111 requested a review from a team October 13, 2023 06:56
@IGI-111 IGI-111 enabled auto-merge (squash) October 13, 2023 09:38
@IGI-111 IGI-111 merged commit ae8a39c into master Oct 13, 2023
27 checks passed
@IGI-111 IGI-111 deleted the esdrubal/associated_types_fully_qualified_types branch October 13, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@tritao tritao tritao approved these changes

Assignees

@esdrubal esdrubal

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esdrubal @tritao @IGI-111