-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function deduplication #5167
Merged
Merged
Function deduplication #5167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a unit test ICE'ing. Changing this to Draft. |
…aivaswatha/fndedup
AsmBlocks are part of an Instruction. When an Instruction is cloned, they must be too. But if they're in the Arena, when an instruction is cloned, we end up with the same AsmBlock being part of two instructions. If a transformation modifies one of it, the other gets modified too, which is incorrect.
This PR, now, also modifies the IR infrstructure to not store |
IGI-111
approved these changes
Oct 4, 2023
tritao
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimisation pass looks for identical functions and eliminates all but one, replacing calls appropriately.
Ideally this must be run before any other pass, to reduce compile times for all the remaining passes. However, when run before inlining, it impacts some inlining decisions. For example, functions which previously had only a single caller now may have multiple callers, thus preventing them from being inlined. While theoretically that could be good, numbers indicated otherwise. The inliner needs to be tuned before we move dedup ahead of it.
Also, the PR has a minor edit to the order in which inlining is performed on inlining candidates. We now follow lexical order rather than relying on an arbitrary order set by
FxHashMap
. This was necessary so that equal functions remain equal after inlining. Changing the order of inlining resulted in differences in the order and names of local variables, rendering functionsthat were equal before inlining to not be anymore.
Closes #5166
Code size impact on sdk-harness contracts/scripts: