Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added keccak256 tests for Hasher #5172

Merged
merged 7 commits into from
Oct 5, 2023
Merged

Added keccak256 tests for Hasher #5172

merged 7 commits into from
Oct 5, 2023

Conversation

brandonsurh
Copy link
Contributor

Description

Closes #5090

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@brandonsurh
Copy link
Contributor Author

The Check Links test failed due to the site docs.rs going down during the check. It needs to be run again. Also, I don't have permissions to add assignees, reviewers, or labels.

@bitzoic bitzoic added good first issue Good for newcomers lib: std Standard library testing General testing labels Oct 5, 2023
@bitzoic bitzoic requested review from bitzoic and a team October 5, 2023 11:09
bitzoic
bitzoic previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@bitzoic bitzoic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for contributing! :shipit:

@bitzoic bitzoic requested a review from a team October 5, 2023 11:10
Braqzen
Braqzen reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Braqzen Braqzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't verified that the resulting hashes are correct so I'm trusting the implementation to produce the correct hashes

sway-lib-std/src/hash.sw Outdated Show resolved Hide resolved
sway-lib-std/src/hash.sw Outdated Show resolved Hide resolved
@brandonsurh @Braqzen
Update sway-lib-std/src/hash.sw
c445308 
Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com>
@brandonsurh @Braqzen
Update sway-lib-std/src/hash.sw
e1f543a 
Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com>
@bitzoic bitzoic requested a review from a team October 5, 2023 14:03
@bitzoic bitzoic merged commit b0ee854 into FuelLabs:master Oct 5, 2023
31 checks passed
@brandonsurh brandonsurh mentioned this pull request Jan 22, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Braqzen Braqzen Braqzen approved these changes

@bitzoic bitzoic bitzoic approved these changes

Assignees

@brandonsurh brandonsurh

Labels
good first issue Good for newcomers lib: std Standard library testing General testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add keccak256 tests for Hasher
3 participants
@brandonsurh @bitzoic @Braqzen