Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix u256 as ref type for configurables #5194

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix u256 as ref type for configurables #5194

merged 1 commit into from
Oct 16, 2023

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Oct 13, 2023 •
edited
Loading

Description

This PR is part of #4794. It fix an issue necessary to use u256 on configurables.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj self-assigned this Oct 13, 2023
@xunilrj xunilrj requested a review from a team October 13, 2023 15:19
@JoshuaBatty JoshuaBatty requested a review from a team October 15, 2023 22:53
@xunilrj xunilrj force-pushed the xunilrj/u256_configurables branch from dc523bb to 15da8de Compare October 16, 2023 12:26
@xunilrj xunilrj merged commit cddd9f6 into master Oct 16, 2023
31 checks passed
@xunilrj xunilrj deleted the xunilrj/u256_configurables branch October 16, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@tritao tritao tritao approved these changes

Assignees

@xunilrj xunilrj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xunilrj @tritao @JoshuaBatty