Introduce recursive analysis via cycle finding in dependency graph.

[tritao]

Description

This PR introduces a new recursive analysis pass, which is implemented for for regular and impl traits functions.

It works computing a dependency graph, and then running the Johnson graph cycle finding algorithm in the graph.

Regular functions still use the old recursive analysis pass due to issues with disabling the old dependency pass. When disabling the old recursion analysis code for regular functions, we get a stack overflow in the existing dependency map building code, which is shared with the existing type recursion analysis code.

Closes #4954.

Checklist

• I have linked to any relevant issues.
• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation where relevant (API docs, the reference, and the Sway book).
• I have added tests that prove my fix is effective or that my feature works.
• I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
• I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
• I have requested a review from the relevant team or maintainers.

[tritao]

This approach still has a few problems, it's currently failing in a few more complex situations due to to the pass getting confused with tracking (non-)monomorphized ids. We'll need to better track between the original unmonorphized id and the monorphized ids. The CFG pass also had the same issue and we solved it by using the parents abstraction on the engines, but this was kinda of a temporary hack. Will be looking into a better way to track this.

[kodiamz-xbldr84]

Not yet send me this msg Le mar. 24 oct. 2023 à 17:33, João Matos ***@***.***> a écrit :

…

This approach still has a few problems, it's currently failing in a few more complex situations due to to the pass getting confused with tracking (non-)monomorphized ids. We'll need to better track between the original unmonorphized id and the monorphized ids. The CFG pass also had the same issue and we solved it by using the parents abstraction on the engines, but this was kinda of a temporary hack. Will be looking into a better way to track this. — Reply to this email directly, view it on GitHub <#5210 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3DTGUX3CXVXFLKCDK5OZN3YA7UUJAVCNFSM6AAAAAA6I3FO76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZXGYYDOMBWGU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>