Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unexpected error while using generic Into trait. #5211

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fixes unexpected error while using generic Into trait. #5211

merged 1 commit into from
Oct 20, 2023

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Oct 20, 2023 •
edited
Loading

Description

Most of the changes in this commit are moving the TypeInfo extract methods into TypeId, this was required by the fix which requires to work with a TypeId instead of TypeInfo.

This commit also improves multiple Display and Debug traits.

The fix changes are in https://github.com/FuelLabs/sway/compare/esdrubal/fix_into_trait_error?expand=1#diff-1b4791151cae4e7986e4d18bcb97e88ec47dfb10231ed1cf50dd247fc5f0bc80R334-R341

After fixing this issue this one appeared #5208

Closes #5209

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal esdrubal added bug Something isn't working P: high Should be looked at if there are no critical issues left compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Oct 20, 2023
@esdrubal esdrubal self-assigned this Oct 20, 2023
@esdrubal esdrubal force-pushed the esdrubal/fix_into_trait_error branch 2 times, most recently from 95bc195 to 7e337fe Compare October 20, 2023 13:41
@esdrubal
Fixes unexpected error while using generic Into trait.
7e337fe 
Most of the changes in this commit are moving the TypeInfo extract methods
into TypeId, this was required by the fix which requires to work with a TypeId
instead of TypeInfo.

This commit also improves multiple Display and Debug traits.

Closes #5209
@esdrubal esdrubal requested a review from a team October 20, 2023 14:46
@IGI-111 IGI-111 requested a review from a team October 20, 2023 14:49
@esdrubal esdrubal merged commit b59aae9 into master Oct 20, 2023
31 checks passed
@esdrubal esdrubal deleted the esdrubal/fix_into_trait_error branch October 20, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@tritao tritao tritao approved these changes

Assignees

@esdrubal esdrubal

Labels
bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen P: high Should be looked at if there are no critical issues left
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected error while using generic Into trait.
3 participants
@esdrubal @tritao @IGI-111