Fix side effects in if-let
expressions
#5215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the critical issue in
if-let
s: #5173if-let
s were desugared tomatch
expressions but used their own implementation for desugaring which wasn't storing the result of the matched value into a compiler generated variable but instead re-evaluated it on every access, causing side effects.The new implementation generates exactly the same desugaring as the equivalent
match
expression would have, simply by forwarding theif-let
desugaring tomatch
desugaring.Since the generated IR is different, the IR gen tests needed to be adapted as well.
Also, a single assert is commented out in the
go_to_definition_for_matches
LSP test until #5221 is solved.Closes #5173.
Checklist
Breaking*
orNew Feature
labels where relevant.