Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR entities must reference their parent #5217

Merged
merged 6 commits into from
Oct 24, 2023
Merged

IR entities must reference their parent #5217

merged 6 commits into from
Oct 24, 2023

Conversation

vaivaswatha
Copy link
Contributor

Description

Closes #4608

The most significant part of this change is renaming the Instruction enum to InstOp and wrapping that with a new Instruction that holds a reference to the parent block. Rest is all a consequence of this change.

@vaivaswatha vaivaswatha requested a review from a team October 23, 2023 06:33
@vaivaswatha vaivaswatha self-assigned this Oct 23, 2023
@vaivaswatha vaivaswatha marked this pull request as draft October 23, 2023 06:48
@vaivaswatha vaivaswatha marked this pull request as ready for review October 24, 2023 00:54
@vaivaswatha vaivaswatha enabled auto-merge (squash) October 24, 2023 10:28
@vaivaswatha vaivaswatha merged commit 9d21152 into master Oct 24, 2023
31 checks passed
@vaivaswatha vaivaswatha deleted the vaivaswatha/issue4608 branch October 24, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@tritao tritao tritao approved these changes

Assignees

@vaivaswatha vaivaswatha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IR data structures must reference their parents
3 participants
@vaivaswatha @tritao @IGI-111