Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move dir helpers from forc-util to sway-utils #5224

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

JoshuaBatty
Copy link
Member

Description

This PR just moves the dir helpers that were in forc-util to sway-utils. I need access to these methods in an upcoming PR and having them in forc-util introduces a mind field of circular dependencies.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty requested review from a team October 25, 2023 01:26
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) October 25, 2023 01:44
@JoshuaBatty JoshuaBatty merged commit b69ea4f into master Oct 25, 2023
31 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/util_refactor branch October 25, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants