Optimize gas for AssetId::new()
and AssetId::default()
functions
#5226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following changes remove the use of the
std::hash::sha256
function in place of assembly to hash theContractId
andSubId
of an asset. As the values hashed are of static length, we can perform the hashing in assembly avoiding the conversion toBytes
and concatenation of the two values done insha256()
These changes result in a 93% reduction in gas usage.
Checklist
Breaking*
orNew Feature
labels where relevant.